PEP 440 compliance: do not implicitly allow pre-releases#543
Merged
radoering merged 2 commits intopython-poetry:mainfrom Jan 20, 2023
Merged
PEP 440 compliance: do not implicitly allow pre-releases#543radoering merged 2 commits intopython-poetry:mainfrom
radoering merged 2 commits intopython-poetry:mainfrom
Conversation
2 tasks
radoering
force-pushed
the
pep-440-pre-release-handling
branch
2 times, most recently
from
56578fc to
1e6e668
Compare
neersighted
requested changes
Jan 20, 2023
Member
neersighted
left a comment
neersighted
left a comment
There was a problem hiding this comment.
LGTM with a negative test (discussed in maintainer's call).
… 440 compliant and counterproductive (If only a prerelease fulfills a constraint, we choose it anyway. If a stable release fulfills a constraint, we shouldn't choose a prerelease if not explicitly requested.)
radoering
force-pushed
the
pep-440-pre-release-handling
branch
from
1e6e668 to
15dd20f
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Member
Author
|
Adapted existing test instead of removing it. |
neersighted
approved these changes
Jan 20, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #402. Besides being a precondition of #402 it's a fix on its own. And it requires some coordination with downstream.
Requires: python-poetry/poetry#7225 and python-poetry/poetry#7236
PEP 440 says:
Nothing special about "
>pre-release" or ">=pre-release"