markers: improve recognition of empty marker in a complex intersections#529
Closed
radoering wants to merge 1 commit intopython-poetry:mainfrom
Closed
markers: improve recognition of empty marker in a complex intersections#529radoering wants to merge 1 commit intopython-poetry:mainfrom
radoering wants to merge 1 commit intopython-poetry:mainfrom
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
|
I added a testcase for an even-more-complex intersection in my MR #528, I leave it with you to consider whether you want to continue down this path to try and make that one work too |
Member
Author
|
Probably not worth it since DNF is a more general approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: python-poetry/poetry-plugin-export#163
Closes: #528
Alternative approach to #528. Includes some minor cleanup to make
MultiMarker.ofandMarkerUnion.ofmore symmetrical (as far as that is possible). The relevant change is the handling ofMultiMarkerin_of_marker_union_and_single_marker.