Skip to content

Comments

Update vendored dependencies#503

Merged
neersighted merged 2 commits intopython-poetry:mainfrom
mkniewallner:update-vendored-dependencies
Oct 11, 2022
Merged

Update vendored dependencies#503
neersighted merged 2 commits intopython-poetry:mainfrom
mkniewallner:update-vendored-dependencies

Conversation

@mkniewallner
Copy link
Member

Update vendored dependencies, mostly to pick up a new version of lark that removes usages of a deprecated method in Python 3.11.

Updates:

@mkniewallner mkniewallner marked this pull request as ready for review October 11, 2022 22:57
@neersighted neersighted force-pushed the update-vendored-dependencies branch from f61337b to fff23b8 Compare October 11, 2022 22:59
@mkniewallner
Copy link
Member Author

mkniewallner commented Oct 11, 2022

Makes me think that we might want to add a CI check that would git diff --exit-code to ensure that vendored modules were correctly generated, whenever anything in vendors or src/poetry/core/_vendor is updated, as a safety measure.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@neersighted
Copy link
Member

I'm not sure I follow how such a check would work -- re-run the vendoring and check there is no diff?

@mkniewallner
Copy link
Member Author

I'm not sure I follow how such a check would work -- re-run the vendoring and check there is no diff?

Yep, that would be the main idea. I'd be happy to set up a quick POC for this.

@neersighted
Copy link
Member

I think at this point, go ahead and do it -- when my long-running CI rework comes to fruition for each repo, I can just incorporate it.

@neersighted neersighted enabled auto-merge (rebase) October 11, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants