respect metadata_directory#487
Merged
neersighted merged 3 commits intopython-poetry:mainfrom Nov 18, 2022
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
neersighted
approved these changes
Nov 18, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced Dec 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes python-poetry/poetry#1078
I'm not sure how useful this really is, but it seems to be what the spec asks for.
It should anyway be an improvement on the half-hearted existing implementation which:
prepare_metadata_for_build_wheel()but then didn't respectmetadata_directoryinbuild_wheel()It might have been even simpler just to remove
prepare_metadata_for_build_wheel()altogether - it's not mandatory - but whatever.pip wheel .executes this code path: that this works is perhaps a more convincing proof that the MR is OK than the unit test.Change in file permission unit test is because I now see these files getting
100644rather than just644. Not entirely sure why that has changed but it seems benign so I've allowed it.