Skip to content

Comments

fix: added 3.11 to list of available pythons#477

Merged
radoering merged 1 commit intopython-poetry:mainfrom
finswimmer:fix/available-pythons
Oct 4, 2022
Merged

fix: added 3.11 to list of available pythons#477
radoering merged 1 commit intopython-poetry:mainfrom
finswimmer:fix/available-pythons

Conversation

@finswimmer
Copy link
Member

@finswimmer finswimmer commented Sep 19, 2022 •
edited
Loading

Python 3.11 is just around the corner, so we have to update this list.

Package.AVAILABLE_PYTHONS is needed in two places:

  1. Adding a classifier when building a wheel (

    poetry-core/src/poetry/core/packages/package.py

    Line 309 in 4535724

    self.AVAILABLE_PYTHONS, key=lambda x: tuple(map(int, x.split(".")))
    )
  2. Finding a suitable interpreter when creating a venv (https://github.com/python-poetry/poetry/blob/2d09741ad67d4fabd94ce6ffd6257c5fec441c12/src/poetry/utils/env.py#L937)

I would prefer a more generic way. So if anyone has a suggestion ...

Downstream tests are fixed in python-poetry/poetry#6561

@finswimmer finswimmer mentioned this pull request Sep 19, 2022
Merged
@finswimmer finswimmer marked this pull request as ready for review September 19, 2022 12:30
@finswimmer finswimmer requested a review from a team September 19, 2022 12:32
@mkniewallner
Copy link
Member

mkniewallner commented Sep 24, 2022

Shouldn't this list be updated to?

poetry-core/src/poetry/core/version/helpers.py

Lines 13 to 26 in d6d33de

PYTHON_VERSION = [
"2.7.*",
"3.0.*",
"3.1.*",
"3.2.*",
"3.3.*",
"3.4.*",
"3.5.*",
"3.6.*",
"3.7.*",
"3.8.*",
"3.9.*",
"3.10.*",
]

@finswimmer finswimmer force-pushed the fix/available-pythons branch 2 times, most recently from 2a4bc87 to 5367933 Compare September 25, 2022 08:06
@finswimmer
Copy link
Member Author

finswimmer commented Sep 25, 2022

Shouldn't this list be updated to?

poetry-core/src/poetry/core/version/helpers.py

Lines 13 to 26 in d6d33de

PYTHON_VERSION = [
"2.7.*",
"3.0.*",
"3.1.*",
"3.2.*",
"3.3.*",
"3.4.*",
"3.5.*",
"3.6.*",
"3.7.*",
"3.8.*",
"3.9.*",
"3.10.*",
]

Good catch 👍

@radoering radoering force-pushed the fix/available-pythons branch from 5367933 to 5e133e5 Compare October 4, 2022 16:36
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@radoering radoering merged commit a10ad40 into python-poetry:main Oct 4, 2022
This was referenced Oct 4, 2022
Merged
Merged
@neersighted neersighted mentioned this pull request Oct 20, 2022
Closed
2 tasks
mwalbeck pushed a commit to mwalbeck/docker-python-poetry that referenced this pull request Jan 10, 2023
@mwalbeck
Update dependency poetry to v1.3.2 (#573)
da51861 
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [poetry](https://python-poetry.org/) ([source](https://github.com/python-poetry/poetry), [changelog](https://python-poetry.org/history/)) | patch | `1.3.1` -> `1.3.2` |

---

### Release Notes

<details>
<summary>python-poetry/poetry</summary>

### [`v1.3.2`](https://github.com/python-poetry/poetry/blob/HEAD/CHANGELOG.md#poetry-core-132-httpsgithubcompython-poetrypoetry-corereleasestag132)

[Compare Source](python-poetry/poetry@1.3.1...1.3.2)

-   Add `3.11` to the list of available Python versions ([#&#8203;477](python-poetry/poetry-core#477)).
-   Fix an issue where caret constraints of pre-releases with a major version of 0 resulted in an empty version range ([#&#8203;475](python-poetry/poetry-core#475)).

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC45NC4wIiwidXBkYXRlZEluVmVyIjoiMzQuOTQuMCJ9-->

Reviewed-on: https://git.walbeck.it/walbeck-it/docker-python-poetry/pulls/573
Co-authored-by: renovate-bot <[email protected]>
Co-committed-by: renovate-bot <[email protected]>
@jakob-keller jakob-keller mentioned this pull request Aug 28, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkniewallner mkniewallner mkniewallner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@finswimmer @mkniewallner @radoering