Merged
Conversation
abn
reviewed
Jul 20, 2020
sdispater
force-pushed
the
add-build-script-without-setup-support
branch
from
620016b to
b238226
Compare
sdispater
force-pushed
the
add-build-script-without-setup-support
branch
from
b238226 to
8eac0ab
Compare
abn
approved these changes
Jul 23, 2020
This was referenced Jul 24, 2020
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we can now disable the generation of the
setup.pyfile, we need a way to make the build scripts feature work without it.This PR takes care of it by assuming that if the generation is disabled and a build script file is referenced then the build script is self sufficient and will take care of compiling and copying necessary files to the project. An example of such a build script has been added to the test fixtures.