Conversation
pretty sure that ~= are always ">=" and "<" so this is only a cosmetic improvement
|
Kudos, SonarCloud Quality Gate passed!
|
neersighted
approved these changes
May 29, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First fix is I think cosmetic in unhittable code, the second finds a new marker simplification at intersection - code is analogous to the similar case in unions
poetry-core/src/poetry/core/version/markers.py
Lines 640 to 647 in 97ab42c
without the fix the intersection looks like
... and python_version <= "3.6" and python_version >= "3.6"