Conversation
This reverts commit f101162.
e2a4e01 to
220a3bb
Compare
|
@abn how should I address the rework? I mean, do you have any suggestions, apart from avoid to rename the attributes? BTW, do you have any instant messaging channel for discussing? |
You can join our discord server. |
|
I'm on the Poetry discord. As suggestion, I'd say do not rename the attribute (as we are not updating the schema property name anyway). And follow a sequence like this to avoid the failure (think it's only an issue in tests). This is off the top of my head, no real validation done.
EDIT: Thinking about one aspect I am not sure about is how any other projects using core would be impacted if |
Reverting #234 because this was an incorrect change as the change meant the wrong version of
poetry-corewas used for testing against downstream poetry. See logs here.Reverting #118 as this is a breaking change. The change needs to be reworked to support existing downstream usage. Alternatively, a change to poetry first to support list of files can also be made.