Skip to content

Comments

Fix: Remove only given package (#4632)#220

Merged
neersighted merged 2 commits intopython-poetry:masterfrom
finswimmer:issue/4632-remove-all-deps
Nov 12, 2021
Merged

Fix: Remove only given package (#4632)#220
neersighted merged 2 commits intopython-poetry:masterfrom
finswimmer:issue/4632-remove-all-deps

Conversation

@finswimmer
Copy link
Member

Fix an issue where all default dependencies were removed instead of just the selected one.

Resolves: python-poetry/poetry#4632

@finswimmer finswimmer requested a review from a team October 13, 2021 19:44
@finswimmer finswimmer changed the title Fix: Remove only give package (#4632) Fix: Remove only given package (#4632) Oct 14, 2021
abn
abn previously requested changes Oct 15, 2021
Copy link
Member

@abn abn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, adding some tests might be appropriate here.

@finswimmer finswimmer requested review from a team and abn November 11, 2021 20:05
Copy link
Member

@neersighted neersighted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for adding tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Poetry uninstalls all dependencies when removing any dependency via poetry remove

3 participants