Path based dev-dependencies break 'install --no-dev' when the dir does not exist#210
Path based dev-dependencies break 'install --no-dev' when the dir does not exist#210ride90 wants to merge 1 commit intopython-poetry:mainfrom
Conversation
…ry does not exist
|
Hello @sdispater , please take a look and let me know if it makes sense, if so I will provide tests and update docs. |
|
Hey, please, any feedback? 🙏 |
|
Hi @sdispater , is there any chance to get a feedback? |
|
Hi @stephsamson , is there any chance to get a feedback from any of the maintainers? |
|
Hey, is it possible to get a feedback? |
|
This would be great to merge. Installing all deps takes between 5 and 10 minutes because changes to the source code causes cache busting for docker containers. This leads to every commit consuming N x 10 minutes longer of build time, where N=3 in our small case. |
|
Hi @sdispater , please can you comment on this? 🙏 |
|
Please @sdispater @abn @dimbleby @radoering @finswimmer @branchvincent, |
|
Sorry for the late feedback. I took a quick look and I have some concerns:
Unfortunately, some logic to determine if a warning is sufficient seems like a brittle fix that will easily break to me. Nevertheless, the |
|
Any progress here? |
|
Since nothing has happened here for quite some time to address the concerns (which might be due to the late feedback), I'm closing this PR in favor of #520, which takes a more general approach. Nevertheless, thanks for your contribution. |
Resolves: python-poetry/poetry#668