support specifying algorithm when calculating file dependency hash.#196
support specifying algorithm when calculating file dependency hash.#196kaos wants to merge 1 commit intopython-poetry:masterfrom
Conversation
Signed-off-by: Andreas Stenius <[email protected]>
|
Ping. Any feedback on this? |
|
I am currently blocked because all the packages in my gemfury repo are md5 signed so we cannot upgrade/install anything using them. Is there any circumvention I can use while we wait for this pr to land? This is a significant blocker for my company. |
|
@wcn00 Yes, the feature toggle I discovered, and present in python-poetry/poetry#4488 should allow you to use the old mechanism for installing dependencies, bypassing this entirely:
I think it was a mistake to enable this new installer by default, would have been better as an opt-in. |
|
Thankyou @kaos You're a gentleperson and a scholar :) Disabling that feature gets me out of this bind which was threatening to ruin my week! |
|
Ping. @finswimmer @abn Thank you. |
|
Bump. I can address conflicts etc, if there is any sign this PR will be getting any review activity. |
|
@kaos Patience. I also once wanted wrote a patch for the same feature. I would estimate you have to wait another year to get it merged. (ref: python-poetry/poetry#2422 for ETA for changes like this) Writing "bump" here just gives notifications to those interested in the feature (like me) but doesn't make things faster |
neersighted
left a comment
There was a problem hiding this comment.
This change is very small and well-tested. While overall I'm not enthusiastic about md5 support, I think we need to take the pragmatic approach here.
|
This was fixed in 68bf052 |
|
Yep -- you're right. I'll take a look at the |
Signed-off-by: Andreas Stenius [email protected]
Pre-work for: python-poetry/poetry#4085
Currently, poetry assumes all archive file hashes are using
sha256. This opens for the ability to support other algorithms. (I have a real use case, where the archive uses md5, for instance.)