Merged
Conversation
abn
previously approved these changes
Mar 30, 2021
Member
abn
left a comment
abn
left a comment
There was a problem hiding this comment.
Minor suggestion regarding deprecation note. Otherwise lgtm.
|
|
||
| ### Changed | ||
|
|
||
| - Dropped support for Python 2.7 and 3.5 ([#131](https://github.com/python-poetry/poetry-core/pull/131)). |
Member
There was a problem hiding this comment.
Might want to add a note for projects still needing this should use an appropriate build requires section.
Member
Author
There was a problem hiding this comment.
You're right. I just added a note to the change log.
sdispater
force-pushed
the
release-1.1.0a1
branch
from
e4ba130 to
4d666b2
Compare
abn
approved these changes
Mar 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
Fixed