Output valid file URLs when building requirements#141
Merged
abn merged 2 commits intopython-poetry:masterfrom Mar 22, 2021
Merged
Output valid file URLs when building requirements#141abn merged 2 commits intopython-poetry:masterfrom
abn merged 2 commits intopython-poetry:masterfrom
Conversation
3 tasks
abn
requested changes
Mar 21, 2021
abn
approved these changes
Mar 22, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: python-poetry/poetry#3818
This code isn't currently covered by a test, but I can add one. I also didn't see any relevant docs to update but can if someone could point me to them.
Similar to the issue fixed by python-poetry/poetry#3121, file/directory dependencies in requirements.txt format (and transitively, in wheels) must be in URL format. Running
pip install .for any poetry project containing a directory dependency will currently fail due to this issue.