Always close the wheel tempfile after writing to it#122
Merged
sdispater merged 2 commits intopython-poetry:masterfrom Jan 29, 2021
Merged
Always close the wheel tempfile after writing to it#122sdispater merged 2 commits intopython-poetry:masterfrom
sdispater merged 2 commits intopython-poetry:masterfrom
Conversation
Contributor
Author
|
It looks like there are linting tests that are failing. I'll get this fixed immediately. Could the linters be run with tox as well? This would let me resolve quality problems prior to pushing. 😄 |
This resolves a crash that occurs on PyPy3 on Windows Closes python-poetry/poetry#3545
kurtmckee
force-pushed
the
fix-poetry-3545
branch
from
ae6ac0b to
124a879
Compare
sdispater
approved these changes
Jan 29, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: python-poetry/poetry#3545
As mentioned in python-poetry/poetry#3545, PyPy3 on Windows does not auto-close the tempfile that is created when building wheels. It appears that CPython auto-closes the file as the zip file context manager exits, but PyPy3 does not, leading to a PermissionError.
There are two commits in this patch:
os.fdopen()call into a context manager.Please let me know if there is anything else that needs to be done, or if you want something accomplished in a different way. Resolving this issue will allow me to run feedparser unit tests on Windows with PyPy3.