Simplify temporary_directory and use safe_rmtree#119
Merged
finswimmer merged 5 commits intopython-poetry:masterfrom Dec 31, 2020
thejcannon:master
Merged
Simplify temporary_directory and use safe_rmtree#119finswimmer merged 5 commits intopython-poetry:masterfrom thejcannon:master
finswimmer merged 5 commits intopython-poetry:masterfrom
thejcannon:master
Conversation
finswimmer
requested changes
Dec 19, 2020
Member
finswimmer
left a comment
finswimmer
left a comment
There was a problem hiding this comment.
Thanks a lot 👍
Just a minor thing.
finswimmer
approved these changes
Dec 31, 2020
Member
finswimmer
left a comment
finswimmer
left a comment
There was a problem hiding this comment.
Thanks a lot and happy new year 🚀
|
Yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: python-poetry/poetry#3493
Unit test fails without changes and passes with changes 🎉