Add support to declare multiple README files#118
Merged
neersighted merged 3 commits intopython-poetry:masterfrom Nov 15, 2021
wagnerluis1982:feature/multiple-readme-files
Merged
Add support to declare multiple README files#118neersighted merged 3 commits intopython-poetry:masterfrom wagnerluis1982:feature/multiple-readme-files
neersighted merged 3 commits intopython-poetry:masterfrom
wagnerluis1982:feature/multiple-readme-files
Conversation
I think so, yes. |
2 tasks
Contributor
Author
|
I rebased my branch to latest |
neersighted
requested changes
Nov 14, 2021
tests/masonry/builders/fixtures/with_readme_files/pyproject.toml
Outdated
Show resolved
Hide resolved
wagnerluis1982
commented
Nov 15, 2021
Contributor
Author
wagnerluis1982
left a comment
wagnerluis1982
left a comment
There was a problem hiding this comment.
Thanks for the awesome suggestions.
I added my fixes to the code: please note that I rebased the branch to reduce the number of commits.
Comments about my fixes:
- I chose
isinstance(config["readme"], list)as the TOML parser only deliverslist-like objects, no need to check fortuple. - About using a
Sequence, please check my separate comment - Pluralized
Package.readme(becamereadmes) andreadme_type=>description_type - Added a test for validation fail when readme types mismatch
- Refactoring according to the comments
- Fixed a few glitches I found on the way
tests/masonry/builders/fixtures/with_readme_files/pyproject.toml
Outdated
Show resolved
Hide resolved
neersighted
previously approved these changes
Nov 15, 2021
neersighted
approved these changes
Nov 15, 2021
abn
added a commit
to abn/poetry-core
that referenced
this pull request
Nov 15, 2021
This reverts commit f101162.
Merged
abn
added a commit
to abn/poetry-core
that referenced
this pull request
Nov 15, 2021
This reverts commit f101162.
This was referenced Nov 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: python-poetry/poetry#873
This code reuses the
"readme"entry in a way to allow the user to declare in the old way or the new way. The two following declarations become valid:Single file
Multiple files
If the user declares files in different formats, the strict validation will issue.