Skip to content

Comments

fix(console.commands.command.Command): restore the set_poetry instance method (removed in Poetry v2)#9981

Merged
abn merged 1 commit intopython-poetry:mainfrom
DavidVujic:issue-9980-restore-Command-set_poetry
Jan 7, 2025
Merged

fix(console.commands.command.Command): restore the set_poetry instance method (removed in Poetry v2)#9981
abn merged 1 commit intopython-poetry:mainfrom
DavidVujic:issue-9980-restore-Command-set_poetry

Conversation

@DavidVujic
Copy link
Contributor

@DavidVujic DavidVujic commented Jan 7, 2025 •
edited by sourcery-ai bot
Loading

Pull Request Check List

Resolves: #9980

  • Added tests for changed code.
  • Updated documentation for changed code.

Summary by Sourcery

Bug Fixes:

  • Restore the set_poetry instance method, addressing compatibility issues with Poetry v2.

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 7, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request restores the set_poetry instance method to the Command class, which was removed in Poetry v2. This method allows setting a Poetry instance on the command object.

Class diagram showing Command class with restored set_poetry method

classDiagram
    class Command {
        -_poetry: Poetry
        +poetry(): Poetry
        +set_poetry(poetry: Poetry): void
        +get_application(): Application
    }
    note for Command "Restored set_poetry method"

    class Poetry {
    }

    class Application {
    }

    Command --> Poetry: has
    Command --> Application: returns
Loading

File-Level Changes

Change Details Files
Restore the set_poetry instance method
  • Added the set_poetry instance method to the Command class.
  • The set_poetry method takes a Poetry object as an argument and sets the _poetry attribute of the command object to the given value.
 src/poetry/console/commands/command.py

Possibly linked issues

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Jan 7, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @DavidVujic - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please add tests for the restored set_poetry method to prevent future regressions
  • Documentation should be updated to explain why this previously removed method is being restored
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@DavidVujic DavidVujic force-pushed the issue-9980-restore-Command-set_poetry branch 2 times, most recently from d01015f to 91666b2 Compare January 7, 2025 17:50
@abn abn enabled auto-merge (rebase) January 7, 2025 18:24
@abn abn force-pushed the issue-9980-restore-Command-set_poetry branch from 91666b2 to 0758b22 Compare January 7, 2025 18:24
@abn abn merged commit 781b4c2 into python-poetry:main Jan 7, 2025
72 checks passed
@DavidVujic DavidVujic deleted the issue-9980-restore-Command-set_poetry branch January 11, 2025 16:34
@radoering radoering mentioned this pull request Jan 11, 2025
Merged
@github-actions
Copy link

github-actions bot commented Feb 11, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@abn abn abn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Poetry 2: restore the set_poetry method on poetry.console.command.Command

2 participants

@DavidVujic @abn