fix: properly close streaming requests when not completely consumed#9899
fix: properly close streaming requests when not completely consumed#9899radoering merged 1 commit intopython-poetry:mainfrom
Conversation
|
I just found that this does not really matter if we were using just We should still be closing the responses here though, as that is what the docs say. |
radoering
left a comment
radoering
left a comment
There was a problem hiding this comment.
Good catch. 👍
Not sure if I need to write test for this, let me know if so.
Do you think a test makes sense? If the only way to test it, is to assert that close() is called, it may not be worth it.
Tasssadar
force-pushed
the
requests_close
branch
from
513a34f to
4df5c6b
Compare
Fixed the exception type. In my opinion, the test do not make much sense, as they would be pretty fragile and would not check any new places where |
|
Hi, when can we expect this being released to pypi? |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
3 participants
https://requests.readthedocs.io/en/latest/user/advanced/#body-content-workflow
In our case, with combination with Artifactory, these open connections are stuck in the middle of a download, because Artifactory does not support the Range requests for lazy wheel.
Not sure if I need to write test for this, let me know if so.