info: require pkginfo >= 1.12 for METADATA 2.4 support and loosen check for unknown METADATA versions#9888
Merged
radoering merged 1 commit intopython-poetry:mainfrom Dec 6, 2024
Conversation
radoering
changed the title
pkginfo >= 1.12 for METADATA 2.4 support and loosen check for unknown METADATA versions
…ck for unknown METADATA versions
radoering
force-pushed
the
metadata-24
branch
from
2b7f148 to
a86bb31
Compare
Secrus
approved these changes
Dec 6, 2024
Member
Secrus
left a comment
Secrus
left a comment
There was a problem hiding this comment.
LGTM, thank you for tackling this issue.
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.8 1.8
# Navigate to the new working tree
cd .worktrees/backport-1.8
# Create a new branch
git switch --create backport-9888-to-1.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a3cae0cb2676bc6408f7205f167fbf4abf72d0be
# Push it to GitHub
git push --set-upstream origin backport-9888-to-1.8
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.8Then, create a pull request where the |
radoering
added a commit
to radoering/poetry
that referenced
this pull request
Dec 6, 2024
…heck for unknown METADATA versions (python-poetry#9888) (cherry picked from commit a3cae0c)
This was referenced Dec 6, 2024
sebhmg
added a commit
to MiraGeoscience/conda-lock
that referenced
this pull request
Dec 13, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: #9885
I think we should do a 1.8 release, which requires
pkginfo >= 1.12to reduce support workload.Further, after some testing I agree to @Secrus' proposal to loosen the check for unknown METADATA versions.
We introduced this check because
pkginfo < 1.11.0did not handle unknown versions well:However,
pkginfo >= 1.11.0handles it better: