doc: add documentation for using extension modules#9864
doc: add documentation for using extension modules#9864abn merged 2 commits intopython-poetry:mainfrom
Conversation
|
Deploy preview for website ready! Built with commit 80bc1fb. |
6864718 to
7525d7e
Compare
8f8d00b to
7f9b79a
Compare
|
@abn : I spotted this PR from your post on the issue, which I've been following. This looks great! Just one thing I noticed - this statement looks mutually contradictory to me? I've personally not tried putting a build script in a subdirectory, but I had thought that it needed to be in the root directory, next to pyproject.toml. |
|
Good catch, I should be clearer there. What I wanted to communicate was that it must in the root or a subdirectory. Where you place the script won't matter as long as it is included in your sdist and referred to correctly within your pyproject file. I will fix it up to be clearer. |
7f9b79a to
2a2d10b
Compare
47da77b to
ce80f31
Compare
radoering
left a comment
There was a problem hiding this comment.
Some first feedback. (I have not looked at the examples in details yet.)
You did not mention generate-setup-file. (Personally, I have no idea if/when you need this setting.) Should it be mentioned?
That's a good thing. I'd personally be glad to see that option gone, since it ties us to |
|
Yes. The non-mention of that option is intentional. Today, it defaults to false, and we may remove it in the future. Especially as the setup file generation is full of holes. |
76b9dd1 to
4932b00
Compare
radoering
left a comment
There was a problem hiding this comment.
I have only skimmed over the examples and have not tried them out, but since there is a warning at the beginning of the section, I think it is ok to publish it and wait for feedback.
Btw, do you want to squash the commits? They have the same message and I do not see that keeping them separate adds any value.
|
Squash is fine. I think I forgot to squash the last push. |
678490d to
80bc1fb
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |

No description provided.