install: make --sync compatible with virtualenvs.options.system-site-packages = true#9863
Merged
abn merged 1 commit intopython-poetry:mainfrom Nov 28, 2024
Merged
Conversation
radoering
force-pushed
the
sync-system-site-packages
branch
from
b2ed989 to
4994505
Compare
Member
|
This seems to have a side-effect when poetry installs a managed package to system-site. It does also removes previously installed packages. podman run --rm -i --entrypoint bash python:3.13 <<EOF
set -xe
python -m pip install -q --root-user-action=ignore --disable-pip-version-check pipx
pipx install --global -q git+https://github.com/python-poetry/poetry.git@refs/pull/9863/head
poetry new foobar
pushd foobar
# we are doing this here to test a specific use case, do not reuse in your environment
poetry config virtualenvs.create false
poetry add pycowsay
poetry remove pycowsay
poetry install --sync
EOF+ python -m pip install -q --root-user-action=ignore --disable-pip-version-check pipx
+ pipx install --global -q git+https://github.com/python-poetry/poetry.git@refs/pull/9863/head
creating virtual environment...
creating shared libraries...
upgrading shared libraries...
determining package name from 'git+https://github.com/python-poetry/poetry.git@refs/pull/9863/head'...
creating virtual environment...
installing poetry from spec 'git+https://github.com/python-poetry/poetry.git@refs/pull/9863/head'...
done! ✨ 🌟 ✨
installed package poetry 2.0.0.dev0, installed using Python 3.13.0
These apps are now globally available
- poetry
+ poetry new foobar
Created package foobar in foobar
+ pushd foobar
/foobar /
+ poetry config virtualenvs.create false
+ poetry add pycowsay
Skipping virtualenv creation, as specified in config file.
Using version ^0.0.0.2 for pycowsay
Updating dependencies
Resolving dependencies...
Package operations: 1 install, 0 updates, 0 removals
- Installing pycowsay (0.0.0.2)
Writing lock file
+ poetry remove pycowsay
Skipping virtualenv creation, as specified in config file.
Updating dependencies
Resolving dependencies...
Package operations: 0 installs, 0 updates, 1 removal
- Removing pycowsay (0.0.0.2)
Writing lock file
+ poetry install --sync
Skipping virtualenv creation, as specified in config file.
Installing dependencies from lock file
Package operations: 0 installs, 0 updates, 6 removals
- Removing argcomplete (3.5.1)
- Removing click (8.1.7)
- Removing packaging (24.2)
- Removing pipx (1.7.1)
- Removing platformdirs (4.3.6)
- Removing userpath (1.9.2)
Installing the current project: foobar (0.1.0) |
Member
Author
This PR does not change anything about that. You can reproduce the same behavior with Poetry 1.8.4. If you replace |
…te-packages = true` Without this fix, we try to uninstall untracked system site packages.
radoering
force-pushed
the
sync-system-site-packages
branch
from
4994505 to
78617df
Compare
Member
|
You are right. Looks like the removal of system packages when create env is false is an existing issue. I have verified that that this change does functionally fix |
abn
approved these changes
Nov 28, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
More or less required for #9855
Without this fix, we try to uninstall untracked system site packages when running
poetry install --sync.