env: fix check whether path is relative to system site packages#9861
Merged
radoering merged 1 commit intopython-poetry:mainfrom Nov 20, 2024
Merged
Conversation
…ust not use SystemEnv, which is Poetry's own env, but env.parent_env, which is the base env)
Secrus
approved these changes
Nov 20, 2024
Member
Secrus
left a comment
Secrus
left a comment
There was a problem hiding this comment.
The code seems fine to me, but I am not sure I get what is wrong here. Could you add some more context on what the bug is?
abn
approved these changes
Nov 20, 2024
Member
Author
The method is used to determine if a package is in the env's site packages or - if the env is a virtual env created with |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are looking into the wrong environment.
We must not use
SystemEnv, which is Poetry's own env, butenv.parent_env, which is the base env.Pull Request Check List