feat: limit build-system to current major version of poetry-core by default#9812
Merged
Secrus merged 1 commit intopython-poetry:mainfrom Oct 30, 2024
Merged
Conversation
Secrus
approved these changes
Oct 30, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Until now when generating a new
pyproject.tomlthere is no version range given forpoetry-corein the[build-system]section.Most people stick to the default. This become a problem as soon as
poetry-coreintroduces a breaking change. While users have control over runtime dependencies in case of any incompatibility, it is not possible to tell which version of the build-system requirements should be used.This is why we should limit the
poetry-coreversion in the[build-system]section to the current major version ofpoetry-coreby default when generating a new `pyproject.toml.