Merged
Conversation
Clearly a mistake in current RE
Contributor
|
I have no idea why the code thinks that If it has never even worked in all these years anyway, that's pretty good evidence that it is safe to remove it. |
radoering
previously requested changes
Oct 15, 2024
Member
radoering
left a comment
radoering
left a comment
There was a problem hiding this comment.
I agree. Let's remove the dist-info part.
Contributor
Author
|
I removed |
radoering
reviewed
Oct 16, 2024
Secrus
approved these changes
Oct 16, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: #9769