Skip to content

Comments

feat: in show {package} output, clarify meaning of 'required by' entries#9750

Merged
Secrus merged 6 commits intopython-poetry:mainfrom
elliot-100:feat/clarify-show-package-required-by-output
Oct 14, 2024
Merged

feat: in show {package} output, clarify meaning of 'required by' entries#9750
Secrus merged 6 commits intopython-poetry:mainfrom
elliot-100:feat/clarify-show-package-required-by-output

Conversation

@elliot-100
Copy link
Contributor

@elliot-100 elliot-100 commented Oct 10, 2024 •
edited
Loading

Pull Request Check List

Resolves: #9749

  • Added tests for changed code.
  • Updated documentation for changed code

Example of actual output before:

> poetry show requests
 name         : requests
 version      : 2.32.3
 description  : Python HTTP for Humans.

dependencies
 - certifi >=2017.4.17
 - charset-normalizer >=2,<4
 - idna >=2.5,<4
 - urllib3 >=1.21.1,<3

required by
 - cachecontrol >=2.16.0

After:

> poetry show requests
 name         : requests
 version      : 2.32.3
 description  : Python HTTP for Humans.

dependencies
 - certifi >=2017.4.17
 - charset-normalizer >=2,<4
 - idna >=2.5,<4
 - urllib3 >=1.21.1,<3

required by
 - cachecontrol requires requests >=2.16.0

@elliot-100
Copy link
Contributor Author

elliot-100 commented Oct 10, 2024

pre-commit.ci autofix

@elliot-100 elliot-100 changed the title In show {package} output, clarify meaning of 'required by' entries feat: in show {package} output, clarify meaning of 'required by' entries Oct 10, 2024
@elliot-100 elliot-100 mentioned this pull request Oct 10, 2024
Closed
2 tasks
radoering
radoering reviewed Oct 11, 2024
View reviewed changes
@Secrus Secrus enabled auto-merge (squash) October 14, 2024 21:28
@Secrus Secrus merged commit 46f3ede into python-poetry:main Oct 14, 2024
@elliot-100
Copy link
Contributor Author

elliot-100 commented Oct 15, 2024

Thank you!

@elliot-100 elliot-100 deleted the feat/clarify-show-package-required-by-output branch October 15, 2024 13:56
Secrus pushed a commit to Secrus/poetry that referenced this pull request Oct 27, 2024
@elliot-100 @pre-commit-ci @Secrus
feat: in show {package} output, clarify meaning of 'required by' en…
08d40c1 
…tries (python-poetry#9750)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Nov 15, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radoering radoering radoering left review comments

@Secrus Secrus Secrus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

poetry show [package] 'required by' output is confusing

3 participants

@elliot-100 @Secrus @radoering