feat(install): add --all-groups flag to install all dependency groups#9744
Conversation
… for installation
|
Please review, feedback welcome. |
Secrus
left a comment
Secrus
left a comment
There was a problem hiding this comment.
LGTM. @radoering, care to take a look?
|
I will take a look tomorrow. |
radoering
left a comment
radoering
left a comment
There was a problem hiding this comment.
LGTM. There is just one thing: python-poetry/poetry-plugin-export#294 introduces --all-groups to poetry export (not yet released). It is the same name; that is good. However, in poetry export --all-groups conflicts with --with and --without. I have no clear preference, but we should make it consistent.
Thanks for reviewing. |
|
Deploy preview for website ready! Built with commit 0b0c838. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
3 participants
This PR adds the
--all-groupsflag topoetry installwhich includes all the dependency groups (including optional groups) for installation. This is a very common use case for projects with multiple optional groups and allows the user to install everything without specifying each group.This feature has been discussed in the past. See e.g. #7605 and #5461. I gave it another shot with an implementation that respects the existing options and flags.
I decided not to go with
--with=allor similar and instead use the explicit flag--all-groups, consistent with the--all-extrasflag. A naming alternative would be--with-all.Options like
--all-groups --without=docsare supported,--all-groups --with=fooignores thewithwith a warning,--all-groups --only=fooresults in an error.Pull Request Check List