Skip to content

Comments

docs: improve explanation of exclude and include#9734

Merged
Secrus merged 5 commits intopython-poetry:mainfrom
radoering:include-exclude-docs
Oct 20, 2024
Merged

docs: improve explanation of exclude and include#9734
Secrus merged 5 commits intopython-poetry:mainfrom
radoering:include-exclude-docs

Conversation

@radoering
Copy link
Member

Pull Request Check List

Resolves: #9691
Requires: python-poetry/poetry-core#773

  • Added tests for changed code.
  • Updated documentation for changed code.

@radoering radoering added the impact/docs Contains or requires documentation changes label Oct 11, 2024
@github-actions
Copy link

github-actions bot commented Oct 11, 2024

Deploy preview for website ready!

✅ Preview
https://website-rdikpnv3c-python-poetry.vercel.app

Built with commit b5eab87.
This pull request is being automatically deployed with vercel-action

@Secrus Secrus added this to the Poetry 2.0 milestone Oct 18, 2024
@radoering radoering force-pushed the include-exclude-docs branch from 1e192e8 to 97cc84d Compare October 18, 2024 12:53
@radoering radoering marked this pull request as ready for review October 18, 2024 13:45
@radoering radoering requested a review from a team October 19, 2024 11:08
@radoering radoering force-pushed the include-exclude-docs branch from 97cc84d to 6cdb9a4 Compare October 20, 2024 08:29
Secrus
Secrus previously approved these changes Oct 20, 2024
Copy link
Member

@Secrus Secrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small nitpick

@Secrus Secrus enabled auto-merge (squash) October 20, 2024 17:03
@Secrus Secrus merged commit 3e5e038 into python-poetry:main Oct 20, 2024
Secrus pushed a commit to Secrus/poetry that referenced this pull request Oct 27, 2024
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2024
@radoering radoering deleted the include-exclude-docs branch December 13, 2025 17:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

impact/docs Contains or requires documentation changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent default behavior of include

3 participants