fix: lock all extra markers in dependencies if package is required by multiple extras#9700
Merged
radoering merged 2 commits intopython-poetry:mainfrom Sep 29, 2024
Merged
Conversation
radoering
requested changes
Sep 22, 2024
Member
radoering
left a comment
radoering
left a comment
There was a problem hiding this comment.
We should add a test for that. In case you do not want to write one, I will take a look next week.
Contributor
Author
|
I have been sitting on this for ages without writing a testcase, apologies for leaving the job half done but I think it is unlikely to happen |
radoering
reviewed
Sep 29, 2024
radoering
changed the title
radoering
approved these changes
Sep 29, 2024
Secrus
pushed a commit
to Secrus/poetry
that referenced
this pull request
Oct 27, 2024
… multiple extras (python-poetry#9700) Co-authored-by: Randy Döring <[email protected]>
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #9636
could do with a testcase really but I doubt that I will have the energy for it. Maybe you will consider this "obviously correct" and low enough risk to merge anyway, maybe it will have to wait for someone who is more motivated to write that testcase
either way I figured this was more useful as a pull request than not