Skip to content

Comments

remove local version specifier at poetry add#9603

Merged
radoering merged 1 commit intopython-poetry:mainfrom
dimbleby:invalid-constraint
Aug 15, 2024
Merged

remove local version specifier at poetry add#9603
radoering merged 1 commit intopython-poetry:mainfrom
dimbleby:invalid-constraint

Conversation

@dimbleby
Copy link
Contributor

@dimbleby dimbleby commented Aug 3, 2024 

$ poetry source add torch https://download.pytorch.org/whl/cpu
Adding source with name torch.

$ poetry add --lock --source torch torch
Using version ^2.4.0+cpu for torch

but ^2.4.0+cpu is not a valid constraint: or anyway it is not valid once it has been converted into a regular version specifier (eg when written to METADATA). Because per PEP440 on inclusive ordered comparison

Local version identifiers are NOT permitted in this version specifier

@dimbleby dimbleby force-pushed the invalid-constraint branch from 11943a6 to c6de190 Compare August 3, 2024 21:40
@radoering radoering merged commit 3ea8a5d into python-poetry:main Aug 15, 2024
@dimbleby dimbleby deleted the invalid-constraint branch August 15, 2024 15:19
@github-actions
Copy link

github-actions bot commented Sep 15, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radoering radoering radoering approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dimbleby @radoering