PoC: automatically create a pinned extra with dependencies pinned from the lock file#9428
Draft
radoering wants to merge 1 commit intopython-poetry:mainfrom
Draft
PoC: automatically create a pinned extra with dependencies pinned from the lock file#9428radoering wants to merge 1 commit intopython-poetry:mainfrom
pinned extra with dependencies pinned from the lock file#9428radoering wants to merge 1 commit intopython-poetry:mainfrom
Conversation
This was referenced Jun 16, 2024
37d41cf to
ab423d8
Compare
ab423d8 to
6b51e99
Compare
6b51e99 to
a5137cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Related-to: #7990
Requires: #9427
It requires a lock file created with #9427 (which is included in this PR).
When running
poetry build, an extra namedpinnedis automatically created1. This extra requires the exact version of all locked dependencies from the main group. Since #9427 writes the resulting markers into the lock file, we can add the correct markers for each extra dependency.Example core metadata generated for Poetry itself:
core metadata of Poetry with `pinned` extra
1 For the PoC, the extra is always created. If we decide to add this feature, we should introduce a flag, which is disabled by default.