Fail command install if cannot be installed#9333
Merged
radoering merged 1 commit intopython-poetry:mainfrom Sep 15, 2024
Merged
Fail command install if cannot be installed#9333radoering merged 1 commit intopython-poetry:mainfrom
radoering merged 1 commit intopython-poetry:mainfrom
Conversation
radoering
requested changes
Apr 24, 2024
Member
radoering
left a comment
radoering
left a comment
There was a problem hiding this comment.
LGTM. I'm just blocking this in case we will release a 1.9 before 2.0. (Currently, I do not think we will but who knows.) Considering the churn the warning caused, I think it would be too early to do this in a minor release.
An error code is returned if the installation command fails. Also the style is changed from warning to error. Tests was updated.
radoering
approved these changes
Sep 15, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An error code is returned if the installation command fails. Also the style is changed from warning to error.
Tests was updated.
Pull Request Check List
Resolves: #8637