lock: make --no-update the default behavior and introduce --regenerate for the previous default behavior#9327
Conversation
|
I believe that it's the right move to switch the default behavior of This change will result in a more user friendly tool since the behavior will be more clear and therefore less experienced users will have less confusion! |
radoering
force-pushed
the
lock-no-update-per-default
branch
from
9c8e67a to
9549014
Compare
radoering
changed the title
--no-update the default behavior and introduce --new for the previous default behavior--no-update the default behavior and introduce --regenerate for the previous default behavior
|
The proposed changes look good to me! Is it a good time to mark this draft as ready for review? |
|
This PR is marked as draft to avoid that it is merged by accident because we only want to do this with a major version bump and it is very likely but not absolutely clear that the next version will be 2.0. I will mark it as ready as soon as this is clarified. The actual review shoud be quite easy because this is a simple change. |
radoering
force-pushed
the
lock-no-update-per-default
branch
from
9549014 to
7a8890a
Compare
…rate` for the previous default behavior
radoering
force-pushed
the
lock-no-update-per-default
branch
from
7a8890a to
e602d5e
Compare
…rate` for the previous default behavior (python-poetry#9327)
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
3 participants
Pull Request Check List
Resolves: #3248
Relates-to: #9136
The most difficult decision (if we want to let this change happen) is the name of the new option (old default behavior).
The old flag was
--no-update. Why not call the new flag--update?Because it's not exactly what it is. It does not update the locked package versions but ignores the lock file and creates a new one from scratch. The result is the same as an update because our (only) locking strategy is "use-latest" but in case we introduce alternative locking strategies in the future (cf #3527) the result will be different. Further, by not calling it
--updatethe difference topoetry update --lockbecomes clearer.