Move to native tags gathering#9304
Merged
Secrus merged 2 commits intopython-poetry:mainfrom Apr 17, 2024
Merged
Conversation
radoering
approved these changes
Apr 17, 2024
Secrus
force-pushed
the
packaging-script
branch
from
8da1ce6 to
7e95162
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: None
- [ ] Added tests for changed code.New code doesn't change the behavior- [ ] Updated documentation for changed code.No user-facing changesThe scripts connected to envs bothered me for quite a while. I have found a way to remove
GET_SYS_TAGSscript, by replacing it with a native implementation. I have also included a few small improvements.