remove advice re seeding keyring backends#9164
Conversation
|
Seeding the venv isn't relevent with the modern installer, but as long as the old installer is still supported it should probably be updated instead of removed. Edit: while I never made a poetry plugin, I did create keyring-subprocess which has a virtualenv seeder since that also worked for the projects at work using pipenv... |
|
... because the pip-based installer is using pip from the project environment: and the issue is not how to get poetry to use the backend, it is how to get that pip to use the backend? thanks, that just about makes sense. given that the pip-based installer is now deprecated I would vote for removing this advice anyway - I am currently in a |
radoering
force-pushed
the
remove-seeder-talk
branch
from
c740ad5 to
5859724
Compare
(cherry picked from commit 75453c2)
neersighted
added
area/docs
|
Deploy preview for website ready! Built with commit 5859724. |
(cherry picked from commit 75453c2)
(cherry picked from commit 75453c2)
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
4 participants
I can't make sense of the advice that this pull request removes: so this is an invitation either to remove it or to explain it!
Surely all that matters to poetry is that the relevant keyring backend is in its own virtual environment? What reason would there be for also seeding the project virtual environment with that backend?
this comes from #4086 so I guess I should tag @Darsstar, though of course three years later it would be completely reasonable to have forgotten or stopped caring.
even if right in principle the doc is not enormously helpful. As far as I am aware the imagined plug-in remains imaginary - and I would not know from reading this text what I was supposed to do anyway. So I might encourage removing it in any case.