Skip to content

Comments

Improve error handling on FIPS systems#9152

Merged
radoering merged 3 commits intopython-poetry:mainfrom
PabloAlexis611:improve-error-handling-on-fips-systems
Mar 18, 2024
Merged

Improve error handling on FIPS systems#9152
radoering merged 3 commits intopython-poetry:mainfrom
PabloAlexis611:improve-error-handling-on-fips-systems

Conversation

@PabloAlexis611
Copy link
Contributor

@PabloAlexis611 PabloAlexis611 commented Mar 14, 2024

Description

This PR improves error handling, particularly in FIPS-enabled systems that are unable to calculate MD5 hashes used for security reasons. If the provided known hash in a link for a dependency is MD5, this PR makes it so that FIPS systems can fallback to SHA256 instead.

Pull Request Check List

Resolves: #9120

  • Added tests for changed code.
  • Updated documentation for changed code.

@PabloAlexis611 PabloAlexis611 requested a review from abn March 14, 2024 02:22
@PabloAlexis611 PabloAlexis611 force-pushed the improve-error-handling-on-fips-systems branch 3 times, most recently from 0f870e9 to f662018 Compare March 15, 2024 16:14
@PabloAlexis611 PabloAlexis611 force-pushed the improve-error-handling-on-fips-systems branch 3 times, most recently from 6d97e29 to a8f2b03 Compare March 17, 2024 18:04
@PabloAlexis611 PabloAlexis611 force-pushed the improve-error-handling-on-fips-systems branch from a8f2b03 to 9700541 Compare March 17, 2024 23:01
@radoering radoering merged commit 52b113d into python-poetry:main Mar 18, 2024
neersighted pushed a commit to neersighted/poetry that referenced this pull request Mar 24, 2024
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

poetry lock --no-update fails on FIPS-enabled system when the only known hash for a dependency is md5

3 participants