Introduce HashManager to work around FIPS#9101
Merged
abn merged 2 commits intopython-poetry:mainfrom Mar 3, 2024
Merged
Conversation
Secrus
force-pushed
the
fips-mode
branch
2 times, most recently
from
12d6849 to
b1a1ba7
Compare
radoering
requested changes
Mar 3, 2024
Member
radoering
left a comment
radoering
left a comment
There was a problem hiding this comment.
Can we put HashManager in a separate module and name the test module after it (for example hash_manager.py and test_hash_manager.py)? IMO, that makes it easier to find relevant unit tests.
eamanu
approved these changes
Mar 3, 2024
Member
Author
Done. I forgot to change the test suite name from the old, initial implementation. |
radoering
approved these changes
Mar 3, 2024
abn
approved these changes
Mar 3, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #8310