Skip to content

Comments

faster PEP517 builds#9094

Merged
abn merged 1 commit intopython-poetry:mainfrom
dimbleby:pep517-simplifications
Mar 2, 2024
Merged

faster PEP517 builds#9094
abn merged 1 commit intopython-poetry:mainfrom
dimbleby:pep517-simplifications

Conversation

@dimbleby
Copy link
Contributor

@dimbleby dimbleby commented Mar 2, 2024 •
edited
Loading

minor simplifications and tweaks to pep517 builds

  • update version of build used during metadata extraction
  • if pep517 metadata extraction fails, don't try fallback to setup.py egg_info
    • eggs are long deprecated
    • using setup.py directly from the command line is deprecated
    • if pep517 builds fail then poetry will later refuse to install the package in any case
  • no need to install setuptools or wheel in the build environments, if they are needed as build requirements then they will be installed as build requirements
  • need pip in the build environment for metadata extraction because we run venv.run_pip(), but don't need it in the build environment during final build

@dimbleby dimbleby force-pushed the pep517-simplifications branch from 1641663 to 2b97bf4 Compare March 2, 2024 12:29
@abn
Copy link
Member

abn commented Mar 2, 2024

For context around the deprecation of the python setup.py <cmd>, future visitors can check https://packaging.python.org/en/latest/discussions/setup-py-deprecated/

@abn
Copy link
Member

abn commented Mar 2, 2024

no need to install setuptools or wheel in the build environments, if they are needed as build requirements then they will be installed as build requirements

I am not sure if we can rely on this assumption yet. However, I suspect we will have to pull the trigger on this one at some point anyway. Now might be as good a time as any.

@abn abn merged commit 0906752 into python-poetry:main Mar 2, 2024
@dimbleby dimbleby deleted the pep517-simplifications branch March 2, 2024 12:53
@github-actions
Copy link

github-actions bot commented Apr 2, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@abn abn abn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dimbleby @abn