be more pessimistic about reading setup.py#9000
Merged
radoering merged 1 commit intopython-poetry:masterfrom Feb 23, 2024
Merged
be more pessimistic about reading setup.py#9000radoering merged 1 commit intopython-poetry:masterfrom
radoering merged 1 commit intopython-poetry:masterfrom
Conversation
if encountering something we don't understand, best assume that we can't get the right answer fixes python-poetry#8774
dimbleby
force-pushed
the
pessimistic-setup-reader
branch
from
e13f91c to
494bb9d
Compare
radoering
approved these changes
Feb 23, 2024
2 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently when parsing setup.py, if poetry encounters something it can't understand it mostly just ignores it
instead, recognise that the parsing didn't succeed - and fall back to an actual build
fixes #8774