Skip to content

Comments

Remove special case for MacOS config directory#8916

Merged
abn merged 3 commits intopython-poetry:mainfrom
Secrus:remove-locations
Feb 25, 2024
Merged

Remove special case for MacOS config directory#8916
abn merged 3 commits intopython-poetry:mainfrom
Secrus:remove-locations

Conversation

@Secrus
Copy link
Member

@Secrus Secrus commented Jan 28, 2024

Time to stop special-casing this, as "new" behavior has been there for quite a while.

@Secrus Secrus requested a review from a team January 29, 2024 10:57
@radoering
Copy link
Member

I would probably postpone this until after Poetry 1.8. The platformdirs 3.0 release was about a year ago and the concerning Poetry release a little bit later. Besides, the code does not hinder our progress so there is no need to hurry, is it? (However, that's not a hill I will die on.)

@Secrus
Copy link
Member Author

Secrus commented Jan 30, 2024

I would probably postpone this until after Poetry 1.8.

Yeah, that was my plan too, just wanted to get the PR out.

@abn abn enabled auto-merge (rebase) February 25, 2024 22:37
@abn abn merged commit 2fb261c into python-poetry:main Feb 25, 2024
@Secrus Secrus deleted the remove-locations branch March 2, 2024 19:34
@github-actions
Copy link

github-actions bot commented Apr 2, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants