Fix documentation for default format option for include and exclude#8852
Merged
radoering merged 2 commits intopython-poetry:masterfrom Jan 10, 2024
Merged
Fix documentation for default format option for include and exclude#8852radoering merged 2 commits intopython-poetry:masterfrom
format option for include and exclude#8852radoering merged 2 commits intopython-poetry:masterfrom
Conversation
Member
Contributor
Author
|
Ah interesting thank you! No wonder I couldn't find it with a search :) |
Contributor
|
cf #8698 |
Contributor
Author
|
As far as I can tell, this should be ready to review — I agree with the discussion in the issue that the documentation should be corrected separately from considering if this behavior is correct. |
radoering
force-pushed
the
zb/include-fix
branch
from
79ffb08 to
07872c8
Compare
|
Deploy preview for website ready! Built with commit 380ffa7. |
radoering
reviewed
Jan 9, 2024
Co-authored-by: Randy Döring <[email protected]>
radoering
approved these changes
Jan 10, 2024
4 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing documentation is incorrect, which confused me when attempting to
includea directory.I verified this behavior by building a package with
includeandexcludeand inspecting the tarballs created.I'd appreciate if someone pointed me to the code for this — I tried to find it but could not :)
Pull Request Check List
Closes #8698