Add a warning about config in the docs for possible faliure point#8850
Merged
radoering merged 4 commits intopython-poetry:masterfrom Jan 5, 2024
Merged
Add a warning about config in the docs for possible faliure point#8850radoering merged 4 commits intopython-poetry:masterfrom
radoering merged 4 commits intopython-poetry:masterfrom
Conversation
radoering
reviewed
Jan 5, 2024
|
Deploy preview for website ready! Built with commit 017aa1c. |
radoering
reviewed
Jan 5, 2024
radoering
approved these changes
Jan 5, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: #4699
There was a mention in #4699 where in a command:
poetry config http-basic.custom-repo gitlab-ci-token ${GITLAB_JOB_TOKEN}if
${GITLAB_JOB_TOKEN}starts with a hyphen (-) the command fails as the parser interprets it as an option being passed.The work-around is to use:
poetry config http-basic.custom-repo -- gitlab-ci-token ${GITLAB_JOB_TOKEN}Where the double hyphen (
--) terminates the options and removes the error.This can be extremely confusing and a warning for the same must be mentioned in the docs.
That is what I've done in the PR by changing the docs to include this warning.