solver: cache only packages for dependencies without extras and use them also for dependencies with extras#8835
Merged
radoering merged 1 commit intopython-poetry:masterfrom Jan 27, 2024
Conversation
This was referenced Dec 31, 2023
radoering
force-pushed
the
dependency-cache-extras
branch
2 times, most recently
from
2a83b5e to
932c25c
Compare
Closed
Secrus
approved these changes
Jan 27, 2024
…hem also for dependencies with extras This way, we can ensure that explicit sources are propagated correctly - no matter if there is a transitive dependency with the same/no/other extras.
radoering
force-pushed
the
dependency-cache-extras
branch
from
932c25c to
e2e6c3b
Compare
4 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way, we can ensure that explicit sources are propagated correctly - no matter if there is a transitive dependency with the same/no/other extras.
Resolves: #8614
Closes: #8802