env: delete entry in envs.toml when running poetry env remove --all#8831
Merged
Secrus merged 1 commit intopython-poetry:masterfrom Jan 4, 2024
Merged
env: delete entry in envs.toml when running poetry env remove --all#8831Secrus merged 1 commit intopython-poetry:masterfrom
poetry env remove --all#8831Secrus merged 1 commit intopython-poetry:masterfrom
Conversation
radoering
force-pushed
the
fix-remove-all
branch
from
250df2b to
b4c38c0
Compare
2 tasks
Secrus
reviewed
Jan 1, 2024
radoering
force-pushed
the
fix-remove-all
branch
from
b4c38c0 to
da0f383
Compare
Secrus
approved these changes
Jan 4, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: #8631
Closes: #8665
Alternative approach to #8665. Just remove the entry in envs.toml when running
poetry env remove --all. This even covers the case that the entry refers to a virtualenv that had been removed manually before.The actual change is in
remove.py. Changes inenv_manager.pyare just refactorings to avoid code duplication and document theenvs.tomlfile a little bit better.