Add output option to build and dist-dir option to publish command#8828
Add output option to build and dist-dir option to publish command#8828radoering merged 11 commits intopython-poetry:masterfrom
output option to build and dist-dir option to publish command#8828Conversation
|
This also requires changes to the publishing setup, since using custom build output would make publishing the built artifacts with Poetry impossible. (This is also where my PR stalled) |
|
Thank for the comment @Secrus, I tried to take it into consideration! |
|
Could you rebase and resolve conflicts? |
benjamin-callonnec
force-pushed
the
master
branch
2 times, most recently
from
3947445 to
dde5956
Compare
Done! |
Secrus
left a comment
Secrus
left a comment
There was a problem hiding this comment.
LGTM. @radoering could you also take a look?
|
Deploy preview for website ready! Built with commit 9c9c143. |
| option( | ||
| "output", | ||
| "o", | ||
| "Set output directory for build artifacts. Default is `dist`.", |
There was a problem hiding this comment.
Normally, we don't use backticks here (only in the docs), but I do not have strong feelings and did not found a reference for something else so 🤷
benjamin-callonnec
force-pushed
the
master
branch
from
dde5956 to
aa3fe9a
Compare
radoering
changed the title
output option to build command.output option to build and dist-dir option to publish command
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
3 participants
Pull Request Check List
outputoption tobuildcommand.dist-diroption topublishcommand.Resolves: #3586
Similar PR: #7208