Improve venv shell activation in fish shell#8804
Merged
radoering merged 1 commit intopython-poetry:masterfrom Dec 20, 2023
Merged
Improve venv shell activation in fish shell#8804radoering merged 1 commit intopython-poetry:masterfrom
radoering merged 1 commit intopython-poetry:masterfrom
Conversation
Instead of mimicking a user typing the command we use fish's builtin `--init-command` option.
Member
|
LGTM. Very good PR description. 👍
Thanks for pointing this out. Should be fine.
Nobody has come up with a sensible way to test this yet. Probably, simple tests would be quite pointless and useful tests are just too much effort. |
radoering
approved these changes
Dec 20, 2023
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of mimicking a user typing the command we use fish's builtin
--init-commandoption. This is similar to howpoetryalready does it innushell. This makes the experience a bit nicer because instead of it looking something like this:it now looks like this (notice the missing
sourceinvokation)The
--init-commandoption has been released withfishversion2.7b1in 2017 according to their changelog so in my opinion should not cause compatibility issues.I didn't find any tests for the nu behavior but would add tests for this if wanted and with some small pointers about how you would like this to be tested.