Skip to content

Comments

normalize gitconfig's author field to UTF-8 NFC#8798

Merged
radoering merged 3 commits intopython-poetry:masterfrom
jmg-duarte:master
Dec 18, 2023
Merged

normalize gitconfig's author field to UTF-8 NFC#8798
radoering merged 3 commits intopython-poetry:masterfrom
jmg-duarte:master

Conversation

@jmg-duarte
Copy link
Contributor

@jmg-duarte jmg-duarte commented Dec 15, 2023

Pull Request Check List

Resolves: #8779

  • Added tests for changed code.
  • Updated documentation for changed code.

Not sure if the checklist is applicable to this one, let me know!

@radoering
Copy link
Member

Can you add a test, please?
(In poetry-core, there is already a test for combine_unicode so I suppose it should be possible to add a test for init, here.)

@jmg-duarte
Copy link
Contributor Author

Can you add a test, please?

Added. Had to make _validate_author static, but it's inline with other validations.

I'm currently just testing for the offending character though, let me know if you know of more troublemakers I should add!

@jmg-duarte jmg-duarte requested a review from radoering December 17, 2023 16:27
@radoering radoering merged commit 951ba48 into python-poetry:master Dec 18, 2023
MrGreenTea pushed a commit to MrGreenTea/poetry that referenced this pull request Dec 18, 2023
@github-actions
Copy link

github-actions bot commented Mar 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

poetry init does not allow é in the authors field

2 participants