Make sdist determinisitic by setting gzip mtime to 0#870
Make sdist determinisitic by setting gzip mtime to 0#870achow101 wants to merge 1 commit intopython-poetry:masterfrom
Conversation
brycedrennan
left a comment
brycedrennan
left a comment
There was a problem hiding this comment.
Interesting. Can you fix the formatting?
Done. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
| self._package.pretty_name, self._meta.version | ||
| ) | ||
| gz = GzipFile(target.as_posix(), mode="wb") | ||
| gz = GzipFile(target.as_posix(), mode="wb", mtime=0) |
There was a problem hiding this comment.
Hello @achow101,
thanks a lot for your contribution. Fixing this looks necessary to me. Are there any reasons for settings the mtime to 0 and not to the current time via time.time()?
fin swimmer
There was a problem hiding this comment.
It's literally the whole point of this PR. A fixed time is needed otherwise the resulting archive is non-deterministic. Setting to time.time() means that the timestamp will continue to be variable which is what I'm trying to fix.
There was a problem hiding this comment.
Ah , sorry it was obviously to late yesterday. The current timestamp is already used if the parameter is omitted and I thought it is something similar to the already merged #1541.
So let's change my question :) Why do you want the file to be deterministic?
There was a problem hiding this comment.
I subscribe to the idea that the releases that you publish should be built in such a way that other people can repeat the build process and produce the exact same files, down to the bit. This makes it much easier to audit the published binaries/archives. https://reproducible-builds.org/ basically explains why.
There's also a bunch of things already in poetry which make the build results more reproducible, so reproducibility is clearly something that is intended in this project.
|
Thanks for your contribution! This looks reasonable to me. Could you rebase your changes onto |
|
Rebased |
|
Apoligies for dropping the ball on this one. Feel free to ping on discord if something falls through the crack again. We appricate your contributions, issues reports, PRs and doc fixes alike. @achow101 this needs to move |
|
@achow101 closing this here as this needs to go to poetry-core now anyway. |
|
Moved to poetry-core: python-poetry/poetry-core#105 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
5 participants
A GZip file contains a timestamp with it's last modification time. This timestamp by default is the current time which will make
poetry buildproduce non-deterministic sdist archives. To make sdist archives deterministic, this timestamp must be set to a fixed time. So this PR sets that time to 0.