remove fancy bullets, just use hyphens#8608
Merged
Secrus merged 4 commits intopython-poetry:masterfrom Nov 13, 2023
Merged
Conversation
71f14bc to
ee017c0
Compare
Secrus
approved these changes
Nov 13, 2023
3 tasks
MrGreenTea
pushed a commit
to MrGreenTea/poetry
that referenced
this pull request
Dec 18, 2023
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the fancy utf-8 bullets are unnecessary trouble: #8603, #3672, #3078, #1427, probably others. Regular hyphens are just fine.
I said in #8603 I wasn't going to do this myself, but
(and then deliberately inserting a fancy bullet in the testcase
test_execute_should_gracefully_handle_io_error)is all there is to it