Skip to content

Comments

remove fancy bullets, just use hyphens#8608

Merged
Secrus merged 4 commits intopython-poetry:masterfrom
dimbleby:remove-fancy-bullets
Nov 13, 2023
Merged

remove fancy bullets, just use hyphens#8608
Secrus merged 4 commits intopython-poetry:masterfrom
dimbleby:remove-fancy-bullets

Conversation

@dimbleby
Copy link
Contributor

@dimbleby dimbleby commented Nov 1, 2023

the fancy utf-8 bullets are unnecessary trouble: #8603, #3672, #3078, #1427, probably others. Regular hyphens are just fine.

I said in #8603 I wasn't going to do this myself, but

sed -i 's/\xe2\x80\xa2/-/g' **/*.py

(and then deliberately inserting a fancy bullet in the testcase test_execute_should_gracefully_handle_io_error)

is all there is to it

@dimbleby dimbleby force-pushed the remove-fancy-bullets branch from 71f14bc to ee017c0 Compare November 1, 2023 20:06
@Secrus Secrus enabled auto-merge (squash) November 13, 2023 11:40
@Secrus Secrus merged commit c710e3a into python-poetry:master Nov 13, 2023
@dimbleby dimbleby deleted the remove-fancy-bullets branch November 13, 2023 12:17
MrGreenTea pushed a commit to MrGreenTea/poetry that referenced this pull request Dec 18, 2023
@github-actions
Copy link

github-actions bot commented Mar 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants