Read description field from setup files#8545
Merged
radoering merged 4 commits intopython-poetry:masterfrom Oct 17, 2023
Merged
Conversation
804d16f to
412d5d4
Compare
radoering
approved these changes
Oct 17, 2023
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
No corresponding issue in the issue tracker.
I work with a project that has a local path dependency and noticed that the description of the local package would get added or removed from
poetry.lockseemingly at random when a new dependency was added or otherwise got updated. The local path dependency usessetup.pyfor historical reasons, and I've identified at least one path in which the description field becomes empty, which is when its metadata gets extracted through static analysis.Minimally reproducible example: https://github.com/ento/poetry/tree/mcve-setup-py-missing-description
Running
poetry lockusing the current master branch (f5cb9f0) produces a lock file with an empty description for the local path dependency like so:This PR updates the
SetupReaderclass to fetch the description field just like how it reads the package name field.