installer: report more details on build failures#8479
Merged
Secrus merged 2 commits intopython-poetry:masterfrom Sep 29, 2023
Merged
installer: report more details on build failures#8479Secrus merged 2 commits intopython-poetry:masterfrom
Secrus merged 2 commits intopython-poetry:masterfrom
Conversation
Closed
Secrus
approved these changes
Sep 29, 2023
4 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Yesterday, I was able to reproduce errors similar to #7611 in python-poetry/poetry-plugin-export#235 for a short time. (After a few runs it suddenly stopped to reproduce.)
Nevertheless, I think I gained a few new insights: The build backend is not available in the isolated venv because the installation of the build system requirements failed! Up to now, we did not check the result of the installation. (I do not know yet why the installation fails because the issue stopped to reproduce after I added additional output.)
In order to provide better error messages and facilitate future investigations, this PR checks the return code of the installation of build system requirements and prints additional information in case of failure.